8000
Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Fix ReadMe#9183

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
rajatvig:fix_readme
Nov 11, 2018
Merged

Fix ReadMe#9183
k8s-ci-robot merged 1 commit intohelm:masterfrom
rajatvig:fix_readme

Conversation

@rajatvig
Copy link
Copy Markdown
Contributor
@rajatvig rajatvig commented Nov 11, 2018

Signed-off-by: Rajat Vig rajat.vig@gmail.com

What this PR does / why we need it:

The last two merges for the Service type + annotation have caused duplication in the ReadMe.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@rajatvig
Fix ReadMe
57c8c42 
Signed-off-by: Rajat Vig <rajat.vig@gmail.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 11, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor
k8s-ci-robot commented Nov 11, 2018
8000

Hi @rajatvig. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2018
@gianrubio
Copy link
Copy Markdown
Collaborator
gianrubio commented Nov 11, 2018

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor
k8s-ci-robot commented Nov 11, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianrubio, rajatvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit ede12d0 into helm:master Nov 11, 2018
anapsix added a commit to anapsix/charts that referenced this pull request Nov 14, 2018
@anapsix
Merge remote-tracking branch 'origin/master' into elasticsearch-allow…
cf8bc0e 
…-chown-failure

* origin/master: (52 commits)
  7931; Enable SSL Support (helm#8935)
  [stable/ghost] Release 5.4.2 (helm#9235)
  [stable/parse] Bump mongodb dependency (helm#9233)
  [stable/postgresql] Add ability to give postgresql, pg_hba configuration or initdb scripts from parameters. (helm#9117)
  [stable/mongodb] Support Prometheus monitoring using Prometheus Operator (helm#9061)
  [stable/postgresql] Fix invalid StatefulSet volumeClaimTemplates annotations if empty. (helm#9115)
  [stable/postgresql] Add affinity parameter. (helm#9114)
  fix typo in livenessProbe (helm#9213)
  [stable/phabricator] Release 3.3.2 (helm#9212)
  upgrade grafana (helm#9223)
  Allow for custom labels and annotations for default rules (helm#9154)
  [stable/percona-xtradb-cluster] Add maver1ck to OWNERS (helm#9178)
  Deprecate Buildkite chart (helm#9200)
  Update elastic-stack to use latest logstash chart (helm#9201)
  Fix broken ingress template for redmine chart (helm#9145)
  [stable/redis] Fix hardcoded serviceName (helm#9187)
  stable/unifi/templates/deployment.yaml: fix probes (helm#9180)
  Fix ReadMe (helm#9183)
  [stable/prometheus-operator] Allow annotations on prometheus service (helm#8867)
  Sync etc and general rules with coreos/prometheus-operator (helm#9103)
  ...
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@rajatvig @wgiddens
Fix ReadMe (helm#9183)
a88708f 
Signed-off-by: Rajat Vig <rajat.vig@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gianrubio gianrubio Awaiting requested review from gianrubio

@seanknox seanknox Awaiting requested review from seanknox

Assignees

@gianrubio gianrubio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rajatvig @k8s-ci-robot @gianrubio @helm-bot
0