This repository was archived by the owner on Feb 22, 2022. It is now read-only.
stable/unifi/templates/deployment.yaml: fix probes#9180
Merged
k8s-ci-robot merged 2 commits intohelm:masterfrom Nov 12, 2018
Merged
stable/unifi/templates/deployment.yaml: fix probes#9180k8s-ci-robot merged 2 commits intohelm:masterfrom
k8s-ci-robot merged 2 commits intohelm:masterfrom
Conversation
Contributor
|
Hi @squat. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The `livenessProbe` and `readinessProbe` are incorrectly defined. The `initialDelaySeconds` field should not be nested withing the `httpGet` field. Signed-off-by: Lucas Serven <lserven@gmail.com>
Signed-off-by: Lucas Serven <lserven@gmail.com>
Member
|
/ok-to-test |
Member
|
thanks @squat 😄 |
billimek
approved these changes
Nov 12, 2018
Collaborator
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: billimek, cpanato, squat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
anapsix
added a commit
to anapsix/charts
that referenced
this pull request
Nov 14, 2018
…-chown-failure * origin/master: (52 commits) 7931; Enable SSL Support (helm#8935) [stable/ghost] Release 5.4.2 (helm#9235) [stable/parse] Bump mongodb dependency (helm#9233) [stable/postgresql] Add ability to give postgresql, pg_hba configuration or initdb scripts from parameters. (helm#9117) [stable/mongodb] Support Prometheus monitoring using Prometheus Operator (helm#9061) [stable/postgresql] Fix invalid StatefulSet volumeClaimTemplates annotations if empty. (helm#9115) [stable/postgresql] Add affinity parameter. (helm#9114) fix typo in livenessProbe (helm#9213) [stable/phabricator] Release 3.3.2 (helm#9212) upgrade grafana (helm#9223) Allow for custom labels and annotations for default rules (helm#9154) [stable/percona-xtradb-cluster] Add maver1ck to OWNERS (helm#9178) Deprecate Buildkite chart (helm#9200) Update elastic-stack to use latest logstash chart (helm#9201) Fix broken ingress template for redmine chart (helm#9145) [stable/redis] Fix hardcoded serviceName (helm#9187) stable/unifi/templates/deployment.yaml: fix probes (helm#9180) Fix ReadMe (helm#9183) [stable/prometheus-operator] Allow annotations on prometheus service (helm#8867) Sync etc and general rules with coreos/prometheus-operator (helm#9103) ...
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* stable/unifi/templates/deployment.yaml: fix probes The `livenessProbe` and `readinessProbe` are incorrectly defined. The `initialDelaySeconds` field should not be nested withing the `httpGet` field. Signed-off-by: Lucas Serven <lserven@gmail.com> * stable/unifi: bump patch version Signed-off-by: Lucas Serven <lserven@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be appli
2DC6
ed from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
livenessProbeandreadinessProbeare incorrectly defined.The
initialDelaySecondsfield should not be nested withing thehttpGetfield.
cc @billimek