Exclude underscore from subshell assignment warnings - #3484
Merged
Conversation
Owner
|
Thanks! |
Contributor
Author
|
Thanks again for merging this. Small process note from our side: Premature Contribution Firewall (PCF) helped us choose this because it was a concrete false positive with no overlapping PR and could stay inside the existing rule/test surface. We'll keep using that gate so future fixes stay small and reviewable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3478.
Summary
_from the subshell assignment warning flow alongside the existing special-case variablesread -r a _ cin a subshell and for reading$_afterwardValidation
cabal test allinhaskell:9.6.6cabal build exe:shellcheckinhaskell:9.6.6cabal exec shellcheck -- /evidence/repro-underscore.shinhaskell:9.6.6