End maintenance cleanup and local feedback reports - #178
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
- Coverage 64.64% 63.22% -1.42%
==========================================
Files 646 644 -2
Lines 79832 70399 -9433
Branches 7201 7228 +27
==========================================
- Hits 51608 44511 -7097
+ Misses 26863 24488 -2375
- Partials 1361 1400 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
https://github.com/niamoto/niamoto/blob/2a330cde915d1b7f8aabf925c62141ce816feb12/media/demo-video/captures/21.site-builder-home-page.png#L1
Deleting this capture leaves scripts/dev/build_readme_hero.sh broken: repo-wide search shows the script still uses media/demo-video/captures/21.site-builder-home-page.png as APP_SHOT (lines 3 and 14), so running it now fails in ImageMagick before it can regenerate assets/screenshots/hero-split.png. Please either keep this source image or repoint the script to an existing copy such as docs/assets/screenshots/desktop/21.site-builder-home-page.png.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Validation
pnpm test -- src/features/feedbackpnpm test -- src/features/feedback/components/FeedbackModal.test.tsxpnpm run buildpnpm run lint(passes with 8 pre-existing warnings outside feedback)cargo fmt --manifest-path src-tauri/Cargo.toml --checkcargo test --manifest-path src-tauri/Cargo.toml --libgit diff --checkNotes
This PR keeps feedback fully local by default. In Tauri, report saving now uses the native save dialog and displays the selected path after a successful save.