fix: use the tracing crate with its original package name. #1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-puzankov-supra
approved these changes
Aug 11, 2025
There was a problem hiding this comment.
We tested this fork in our project and it seems to be working good.
ipetkov
added a commit
to 1Password/async-graphql
that referenced
this pull request
Sep 8, 2025
fix: use the tracing crate with its original package name. Upstream PR: async-graphql/async-graphql#1728
Contributor
|
Any progress on merging this? |
|
any progress on this? |
Contributor
Author
|
I'm also waiting for this PR to be reviewed. @sunli829 , what do you think about this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates the use of the
tracingcrate to align with recent changes in its upstream release, removing the use of thetracinglibalias.Changes
Cargo.tomlto refer to thetracingcrate directly, instead of using thetracinglibalias."tracing"feature declaration to usedep:tracingfor clarity and alignment with Cargo best practices.dataloader,extensions::tracing) to use the standardtracingcrate directly.Reasons for Changes
tracing-attributescrate, which made the alias approach no longer viable.