Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defining the
ISystemResetinterface in some plugins and not in others create a problematic situation in which some plugins are restarted in a way (calling the destructor and constructor) and some other in another way (calling the reset method). This resulted in unexpected behaviour as the one reported in #206 .To solve at least the crash, this PR removes all the reset methods. The downside of this is that now all the YARP ports are closed and re-opened at each reset, but anyhow this is better then just crash.
Implementing a smarter reset strategy that does not restart the ports (that by the way is how Gazebo Classic and gazebo-yarp-plugins worked) will be tracked in #235 .