8000
Skip to content

feat: support EC2 DescribeInstanceStatus health checks in the interruption controller#9064

Open
AndrewMitchell25 wants to merge 7 commits intoaws:mainfrom
AndrewMitchell25:describe-instance-status
Open

feat: support EC2 DescribeInstanceStatus health checks in the interruption controller#9064
AndrewMitchell25 wants to merge 7 commits intoaws:mainfrom
AndrewMitchell25:describe-instance-status

Conversation

@AndrewMitchell25
Copy link
Copy Markdown
Contributor
@AndrewMitchell25 AndrewMitchell25 commented Apr 8, 2026 •
edited
Loading

Fixes #N/A

Description
Builds on #8899

How was this change tested?
Added unit tests and integration tests, both run in CI

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AndrewMitchell25 AndrewMitchell25 requested a review from a team as a code owner April 8, 2026 22:48
@github-actions
Copy link
Copy Markdown
Contributor
github-actions bot commented Apr 8, 2026 •
edited
Loading

Preview deployment ready!

Preview URL: https://pr-9064.d18coufmbnnaag.amplifyapp.com

Built from commit 5e9fed934ad939d885db8b27d957249d2022d858

@AndrewMitchell25 AndrewMitchell25 force-pushed the describe-instance-status branch from fa9fc1b to 1518c56 Compare April 8, 2026 23:07
DerekFrank
DerekFrank reviewed Apr 15, 2026
View reviewed changes
Comment thread pkg/controllers/interruption/controller.go Outdated
AndrewMitchell25
AndrewMitchell25 commented Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author
@AndrewMitchell25 AndrewMitchell25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Copy Markdown
Contributor
github-actions bot commented Apr 16, 2026

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-3ee73392e3f73994b44cb34479de098943ef1095.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-3ee73392e3f73994b44cb34479de098943ef1095" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@AndrewMitchell25 AndrewMitchell25 force-pushed the describe-instance-status branch 2 times, most recently from b2b0242 to 4d0a61d Compare April 17, 2026 18:44
AndrewMitchell25
AndrewMitchell25 commented Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author
@AndrewMitchell25 AndrewMitchell25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Copy Markdown
Contributor
github-actions bot commented Apr 17, 2026

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4d0a61dba7557af4fdcc326d52a9af4fb7d373b9.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4d0a61dba7557af4fdcc326d52a9af4fb7d373b9" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@AndrewMitchell25 AndrewMitchell25 force-pushed the describe-instance-status branch from 4d0a61d to 5e9fed9 Compare April 17, 2026 20:21
AndrewMitchell25
AndrewMitchell25 commented Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author
@AndrewMitchell25 AndrewMitchell25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Copy Markdown
Contributor
github-actions bot commented Apr 17, 2026

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-5e9fed934ad939d885db8b27d957249d2022d858.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-5e9fed934ad939d885db8b27d957249d2022d858" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DerekFrank DerekFrank DerekFrank left review comments

@sumukha-radhakrishna sumukha-radhakrishna Awaiting requested review from sumukha-radhakrishna sumukha-radhakrishna is a code owner automatically assigned from aws/karpenter

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewMitchell25 @DerekFrank @bwagner5
0