E56B
Skip to content

refactor(http_request_node): apply DI for http request node#30509

Merged
laipz8200 merged 11 commits intomainfrom
2932-node-di-httprequ
Jan 14, 2026
Merged

refactor(http_request_node): apply DI for http request node#30509
laipz8200 merged 11 commits intomainfrom
2932-node-di-httprequ

Conversation

@laipz8200
Copy link
Copy Markdown
Member
@laipz8200 laipz8200 commented Jan 4, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

part of #30506

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@gemini-code-assist
Copy link
Copy Markdown
Contributor
gemini-code-assist bot commented Jan 4, 2026

Summary of Changes

Hello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the http_request_node by implementing Dependency Injection (DI) for its critical external dependencies, including HTTP client operations and file management. The primary goal is to decouple the http_request_node from concrete implementations of these services, making the code more flexible, easier to test, and more maintainable. This is achieved through the introduction of Protocol definitions and constructor-based injection across the Executor, HttpRequestNode, and NodeFactory classes.

Highlights

  • Dependency Injection (DI) Implementation: The core change involves refactoring the http_request_node to utilize Dependency Injection for its external services, such as the HTTP client and file manager. This enhances modularity and testability.
  • Introduction of Protocols: New HttpClientProtocol and FileManagerProtocol interfaces have been defined using Python's Protocol type. These protocols specify the expected methods and exceptions for HTTP client and file management operations, enabling clearer contracts for dependencies.
  • Executor Refactoring: The Executor class within the http_request_node now accepts instances of HttpClientProtocol and FileManagerProtocol via its constructor. All internal calls to HTTP requests and file downloads have been updated to use these injected dependencies instead of global imports.
  • HttpRequestNode and NodeFactory Updates: The HttpRequestNode constructor has been extended to accept injected HTTP client, file manager, and a factory for ToolFileManager. The NodeFactory is now responsible for providing these dependencies when creating an HttpRequestNode instance, ensuring that the DI pattern is applied throughout the node creation process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 4, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the HttpRequestNode and its Executor to introduce dependency injection for HTTP client and file management functionalities. It defines HttpClientProtocol and FileManagerProtocol, updates the constructors of Executor and HttpRequestNode to accept injected instances of these protocols (defaulting to ssrf_proxy and file_manager), and modifies internal calls to use these injected dependencies. The NodeFactory is also updated to pass these dependencies when creating an HttpRequestNode. A review comment points out a bug where the HttpClientProtocol incorrectly includes RequestError as an attribute, which causes a runtime AttributeError because the default ssrf_proxy client does not expose this attribute directly, instead raising httpx.RequestError. The reviewer suggests removing RequestError from the protocol and catching httpx.RequestError directly in the Executor's _do_http_request method.

Comment thread api/core/workflow/nodes/http_request/executor.py Outdated
Comment thread api/core/workflow/nodes/http_request/executor.py Outdated
@laipz8200 laipz8200 marked this pull request as ready for review January 4, 2026 10:44
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Jan 4, 2026
@laipz8200 laipz8200 force-pushed the 2932-node-di-httprequ branch 3 times, most recently from e32c5fa to 56fd68f Compare January 4, 2026 16:29
@laipz8200 laipz8200 marked this pull request as draft January 4, 2026 16:30
@laipz8200 laipz8200 marked this pull request as ready for review January 4, 2026 16:35
@laipz8200 laipz8200 force-pushed the 2932-node-di-httprequ branch from 90e30a3 to 4646e39 Compare January 5, 2026 05:47
@laipz8200 laipz8200 requested a review from fatelei January 5, 2026 08:56
fatelei
fatelei reviewed Jan 5, 2026
View reviewed changes
Comment thread api/core/helper/ssrf_proxy.py Outdated
@laipz8200 laipz8200 force-pushed the 2932-node-di-httprequ branch from 6f0058e to 1c1164e Compare January 5, 2026 09:08
@laipz8200 laipz8200 force-pushed the 2932-node-di-httprequ branch from 1c1164e to 75a1585 Compare January 14, 2026 05:51
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 14, 2026
@laipz8200 laipz8200 merged commit 01f17b7 into main Jan 14, 2026
14 checks passed
@laipz8200 laipz8200 deleted the 2932-node-di-httprequ branch January 14, 2026 06:19
This was referenced Jan 21, 2026
Open
Open
Open
Open
This was referenced Jan 21, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fatelei fatelei fatelei approved these changes

@QuantumGhost QuantumGhost Awaiting requested review from QuantumGhost QuantumGhost is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@laipz8200 @fatelei
0