Apply additional style properties to tt:image, allow @style on tt:image (#232). - #234
Merged
Merged
Conversation
nigelmegitt
reviewed
Jan 20, 2017
Contributor
There was a problem hiding this comment.
This introduces the idea that style applies to image, but not that such a style can be animated. Should the set element be permitted as a child of image? Similarly should the animate attribute be permitted on image elements?
Or is there a strong reason why image is an exception and is a "stylable" element whose style may not be animated?
Collaborator
Author
|
Good points. I'll add.
…On Fri, Jan 20, 2017 at 3:37 AM, Nigel Megitt ***@***.***> wrote:
***@***.**** commented on this pull request.
This introduces the idea that style applies to image, but not that such a
style can be animated. Should the set element be permitted as a child of
image? Similarly should the animate attribute be permitted on image
elements?
Or is there a strong reason why image is an exception and is a "stylable"
element whose style may not be animated?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#234 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAXCb7whQWlMEMHHz1A5twp2il77oy4Qks5rUI5agaJpZM4LooEi>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #232.