haskell.compiler: apply LLVM split sections fix unconditionally - #556637
Open
liberodark wants to merge 1 commit into
Open
haskell.compiler: apply LLVM split sections fix unconditionally#556637liberodark wants to merge 1 commit into
liberodark wants to merge 1 commit into
Conversation
nixpkgs-ci
Bot
requested review from
a team,
guibou,
maralorn,
sternenseemann and
wolfgangwalther
August 26, 2026 06:46
wegank
approved these changes
Aug 26, 2026
sternenseemann
previously requested changes
Aug 26, 2026
Member
There was a problem hiding this comment.
If split section should also work for the windows target here, we should probably amend the enableSplitSections condition to be always true when this patch is applied.
Member
|
The patch here concerns the LLVM backend, but I think Windows uses the NCG backend? |
Member
|
Hm true, maybe I conflated this patch with the one that is in 9.14.2 (?) that fixes split sections on windows. |
wolfgangwalther
approved these changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Diff LGTM
(I assume it makes no sense to put this through haskell-updates, because we're not testing the LLVM backend there anyway)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to : #549823 (comment)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.