refactor(color-picker-swatch, focus-trap)!: drop internal components - #14989
Draft
jcfranco wants to merge 2 commits into
Draft
refactor(color-picker-swatch, focus-trap)!: drop internal components#14989jcfranco wants to merge 2 commits into
jcfranco wants to merge 2 commits into
Conversation
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
Removes the following internal components:
focus-trap– no longer needed due to enhancements topanelfocus-trapping and Distribute controllers for external use #14499color-picker-swatch– replaced byswatchBREAKING CHANGE: The
focus-trapandcolor-picker-swatchinternal components have been removed.To migrate:
focus-trapusage withpanel's built-in focus-trapping functionality.color-picker-swatchusage withswatch.