E571
Skip to content

Remove stale @types/ip devDependency across 5 function packages#59

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/fix-ip-ssrf-issue
Draft

Remove stale @types/ip devDependency across 5 function packages#59
Copilot wants to merge 2 commits intomainfrom
copilot/fix-ip-ssrf-issue

Conversation

Copy link
Copy Markdown
Contributor
Copilot AI commented Apr 10, 2026 •
edited
Loading

CVE-2024-29415 flags the ip package's isPublic() for SSRF via improper IP categorization. The vulnerable ip runtime package was already removed in PR #58 (replaced with ipaddr.js), but @types/ip was left behind in 5 function directories.

Changes

  • Removed unused @types/ip from devDependencies in:
    • functions/helpers/closeSecret
    • functions/helpers/getSecretDetails
    • functions/helpers/githubIssueNotifier
    • functions/remediators/remediateAWSAccessKey
    • functions/remediators/remediateGoogleAPIKey
  • Regenerated package-lock.json and yarn.lock for each

Reachability Assessment

Not reachable (high confidence). The ip package is absent from all manifests, lock files, and node_modules. No source file imports ip or calls isPublic. No patched version exists; removal is the correct remediation. This cleanup eliminates all remaining ip-related packages to help Dependabot dismiss the stale alert.

Pre-existing issues

remediateGoogleAPIKey has TS2322 errors on main related to Google Auth types — unrelated to this change.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>ip SSRF improper categorization in isPublic</alert_title>
<alert_description>The ip package through 2.0.1 for Node.js might allow SSRF because some IP addresses (such as 127.1, 01200034567, 012.1.2.3, 000:0:0000::01, and ::fFFf:127.0.0.1) are improperly categorized as globally routable via isPublic. NOTE: this issue exists because of an incomplete fix for CVE-2023-42282.</alert_description>

high
GHSA-2p57-rm9w-gvfp, CVE-2024-29415
ip
npm
<vulnerable_versions>2.0.1</vulnerable_versions>
<patched_version></patched_version>
<manifest_path>functions/authorizers/githubWebhookSecretValidator/package-lock.json</manifest_path>

https://nvd.nist.gov/vuln/detail/CVE-2024-29415 https://github.com/indutny/node-ip/issues/150 https://github.com/indutny/node-ip/pull/143 https://github.com/indutny/node-ip/pull/144 https://security.netapp.com/advisory/ntap-20250117-0010 https://github.com/advisories/GHSA-2p57-rm9w-gvfp

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the package no longer resolves to a version in the vulnerable range. Keep changes minimal and tightly scoped. Ensure tests, build, type checking, and linting all pass after your changes. If there are any test, lint, or typechecking failures, investigate whether they are caused by the update and fix them if so — do not leave broken tests in the PR. If they were already present before the update, note them in the PR description so a human reviewer can assess whether they are related.</task_instructions>

  • Resolves advanced-security/GSSAR alert #181

Copilot AI changed the title [WIP] Fix SSRF improper categorization in ip package Remove stale @types/ip devDependency across 5 function packages Apr 10, 2026
Copilot AI requested a review from felickz April 10, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felickz felickz Awaiting requested review from felickz

Assignees

@felickz felickz

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felickz
0