x509.name.new: guard against non-table array elements (nil deref crash) - #414
Open
samchang8826 wants to merge 1 commit into
Open
x509.name.new: guard against non-table array elements (nil deref crash)#414samchang8826 wants to merge 1 commit into
samchang8826 wants to merge 1 commit into
Conversation
x509.name.new{ "CN=x" } (array of strings) passed the luaL_checktable +
rawlen>0 checks in openssl_xname_new, then openssl_new_xname ran lua_next
on the string element, treating it as a table -> luaH_next dereferenced a
NULL array pointer and crashed the whole process (pcall cannot catch a
segfault).
Check each array element with lua_istable before iterating it, and return
nil+error instead of crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x509.name.new{ "CN=x" } (array of strings) passed the luaL_checktable + rawlen>0 checks in openssl_xname_new, then openssl_new_xname ran lua_next on the string element, treating it as a table -> luaH_next dereferenced a NULL array pointer and crashed the whole process (pcall cannot catch a segfault).
Check each array element with lua_istable before iterating it, and return nil+error instead of crashing.
Description
Please provide a clear and concise description of your changes.
Related Issue
Fixes #(issue number)
Type of Change
Changes Made
Please list the specific changes made in this PR:
Testing
Please describe the tests you ran to verify your changes:
Checklist
OpenSSL Compatibility
Please indicate which OpenSSL versions were tested (if applicable):
Additional Notes
Add any other context about the pull request here.
For development roadmap and planning, see: