awagner-mainz · 2023-10-04T22:42:32Z

Now it works inside "custom" connector
Now it can handle several values per lookup, e.g. @ref and @key
It can work with reconciliation servers running different versions of the protocol

joewiz · 2023-10-05T01:35:11Z

joewiz commented

Oct 5, 2023

•

Sounds nice! Just some suggestions with an eye toward a cleaner PR, if it's not too much trouble:

The version number commit should be removed (version numbers are typically changed when new releases are prepped, not in the course of a feature PR).
Ideally, the merge commit should be removed. This could be fixed with by rebasing against master and performing a force push to your branch.

awagner-mainz · 2023-10-05T06:02:31Z

Sounds nice! Just some suggestions with an eye toward a cleaner PR, if it's not too much trouble:

The version number commit should be removed (version numbers are typically changed when new releases are prepped, not in the course of a feature PR).

Ideally, the merge commit should be removed. This could be fixed with by rebasing against master and performing a force push to your branch.

Cool, I will try to do as you say. I am not particularly experienced with rebasing, reverting and such, so I hope I'll not botch up everything.
(The version number I had to increase in order not to get confused during my local testing, but it's obv no problem to set it back.)

Thanks for looking into it!

awagner-mainz · 2023-11-03T08:35:21Z

Is there any further action required on my part or are things taking their course? I don't mean to rush, just want to make sure things are not waiting for something to happen on my end.

wolfgangmm · 2023-11-04T09:00:16Z

Looks great. My only worry is that you reformatted annotations.js and annotate.html, so it's hard to see actual changes. We're also working on a new version of the annotation interface (see branch feature/annotation-ng) and I'd surely like to pick and merge your changes into the new version as well.

Did you change a lot in those two files?

awagner-mainz · 2023-11-04T15:56:26Z

:eek: 😱 Sorry, I did not mean to do the reformatting (probably it was an automatic pretty-printing at some point). I'll try and see if I can roll this back! Also, I think it will be good if I check the conflicts in the corresponding tei-publisher-components pull request (eeditiones/tei-publisher-components#168), for the two pull requests kind of need to go hand in hand. And while I'm there, I might also have a look at the feature/annotation-ng branch. (Is there any information about the goals of this overhaul?)

So there is in fact things that have to happen on my end 😉
I'll report back!

awagner-mainz force-pushed the master branch from 258add8 to 22e93f1 Compare October 5, 2023 06:57

awagner-mainz closed this Aug 28, 2024

awagner-mainz force-pushed the master branch from 22e93f1 to 2ef1cc0 Compare August 28, 2024 16:35

Navigation Menu

Uh oh!

Uh oh!

Updates to reconciliation API authority connector - #204