feature: Add support for Exportify csv format & make operation option mandatory#2594
Open
Drumba08 wants to merge 3 commits intospotDL:devfrom
Open
feature: Add support for Exportify csv format & make operation option mandatory#2594Drumba08 wants to merge 3 commits intospotDL:devfrom
Drumba08 wants to merge 3 commits intospotDL:devfrom
Conversation
spotdl/utils/arguments.py: Add --load-exportify flag. Allow query to be empty if --load-exportify is set. spotdl/console/entry_point.py: Read the csv and append its contents to the query.
spotdl/utils/arguments.py: "operation" doesn't default to "download" anymore, it now has to be manually set.
"download" as default anymore.
|
I love you. This worked like a charm, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: Add support for Exportify csv format & make operation option mandatory
Implements the flag --load-exportify. It can now be used to load songs directly from the Exportify generated csv.
The format of it can be found here.
Also when I started using spotdl, I found it really confusing that the operation option isn't actually required, but when adding multiple songs to the query it tries to take the first one as operation, so you have to use it again. Also, I needed to allow zero arguments as query, in case of --load-exportify being used, and handle exceptions manually, which makes this behavior even worse, so I thought it would be better to just make setting the operation mandatory.
With this being a pretty intrusive change please let me know how you feel about it, or if there is a better way of doing this.
I think it's very useful for people who don't know how to convert their playlists themself.
Related Issue
#2586
How Has This Been Tested?
works fine on:
Python 3.13.11
6.18.5-arch1-1
pylint score 10.0
Types of Changes
Checklist