fix(song): handle missing genres key in API response#2629
Open
BillionClaw wants to merge 1 commit intospotDL:masterfrom
Open
fix(song): handle missing genres key in API response#2629BillionClaw wants to merge 1 commit intospotDL:masterfrom
BillionClaw wants to merge 1 commit intospotDL:masterfrom
Conversation
Fix KeyError when Spotify API doesn't return genres field for album or artist. Use .get() with default empty list to safely handle missing keys. Fixes spotDL#2619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix KeyError when Spotify API doesn't return genres field for album or artist metadata.
The code at line 117 in song.py assumed that both raw_album_meta and raw_artist_meta would always contain a 'genres' key. However, the Spotify API may omit this field in some cases, causing a KeyError.
Changed to use .get("genres", []) for safe access with a default empty list.
Fixes #2619