8000
Skip to content

feat: fix track search #2594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KRTirtho merged 2 commits into from
Mar 28, 2025
Merged

feat: fix track search #2594

KRTirtho merged 2 commits into from
Mar 28, 2025

Conversation

@ehfd
Copy link
Contributor
@ehfd ehfd commented Mar 24, 2025 •
edited
Loading

Partially solves #883

@ehfd ehfd changed the base branch from master to dev March 24, 2025 08:48
@ehfd ehfd changed the title Add ISRC song search for YouTube Add ISRC track search for YouTube Mar 24, 2025
@KRTirtho
Copy link
Owner
KRTirtho commented Mar 24, 2025

That's a great addition. But does it work for all tracks, tho? Less popular track is what suffers most when matching

@KRTirtho
Copy link
Owner
8000 KRTirtho commented Mar 24, 2025

We already use song.link for the exact task. If isrc doesn't match, that will only make extra requests to YouTube?
Btw with song.link we don't even have to search. It's like a database of already matched Spotify to YouTube, Soundcloud tracks

@KRTirtho
Copy link
Owner
KRTirtho commented Mar 24, 2025 •
edited
Loading

So I just searched with one of my regional Bengali tracks (DGA052354009) corresponding to this Spotify track https://open.spotify.com/track/1stU529KMabUofF9CFm2rn

It surely loads a random YT shorts

@KRTirtho
Copy link
Owner
KRTirtho commented Mar 24, 2025

Just search and you'll find nothing. Although the artist never released the track in YouTube in the first place. It's some other random channels that uploaded it there.
image

KRTirtho
KRTirtho requested changes Mar 26, 2025
View reviewed changes
@KRTirtho
Copy link
Owner
KRTirtho commented Mar 28, 2025

Ok, I'll test and see if everything works perfectly and merge onwards

@KRTirtho
Copy link
Owner
KRTirtho commented Mar 28, 2025

Great work @ehfd
I tested all the core functionalities, and it's working great. Thanks for the contribution

@KRTirtho KRTirtho merged commit 2c4cc94 into KRTirtho:dev Mar 28, 2025
1 check passed
@ehfd ehfd deleted the isrc branch March 28, 2025 17:22
@ehfd ehfd mentioned this pull request Mar 29, 2025
Closed
1 task
@ehfd ehfd changed the title Add ISRC track search for YouTube ISRC track search for YouTube Apr 3, 2025
@ehfd ehfd changed the title ISRC track search for YouTube feat: ISRC track search for YouTube Apr 6, 2025
@ehfd ehfd changed the title feat: ISRC track search for YouTube feat: track search May 11, 2025
@ehfd ehfd changed the title feat: track search feat: fix track search May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KRTirtho KRTirtho KRTirtho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect, Mismatching Tracks Played

2 participants

@ehfd @KRTirtho
0