10BC0
Skip to content

Check plugin name is not used#31427

Merged
banjoh merged 3 commits intohelm:mainfrom
tisonkun:resolve-todo
Jan 9, 2026
Merged

Check plugin name is not used#31427
banjoh merged 3 commits intohelm:mainfrom
tisonkun:resolve-todo

Conversation

@tisonkun
Copy link
Copy Markdown
Contributor
@tisonkun tisonkun commented Oct 28, 2025

What this PR does / why we need it:

Resolve TODOs in code.

Special notes for your reviewer:

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2025
TerryHowe
TerryHowe requested changes Oct 28, 2025
View reviewed changes
Comment thread pkg/cmd/load_plugins.go Outdated
@robertsirc
Copy link
Copy Markdown
Member
robertsirc commented Oct 28, 2025

@tisonkun the build has some issues could you take a look.

@tisonkun
Copy link
Copy Markdown
Contributor Author
tisonkun commented Oct 28, 2025 •
edited
Loading

@robertsirc test failed because out current testdata have a plugin that conflicts with existing command name env.

Shall we rename the plugin pkg/cmd/testdata/helmhome/helm/plugins/env to something like shortenv?

@tisonkun
Copy link
Copy Markdown
Contributor Author
tisonkun commented Oct 30, 2025 •
edited
Loading

I'll change the test plugin name to shortenv later.

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2025
@tisonkun
Copy link
Copy Markdown
Contributor Author
tisonkun commented Nov 2, 2025

cc @robertsirc may you trigger CI workflow again?

@TerryHowe TerryHowe mentioned this pull request Nov 4, 2025
Closed
TerryHowe
TerryHowe previously approved these changes Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor
@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tisonkun tisonkun requested a review from robertsirc November 5, 2025 03:49
@tisonkun
Copy link
Copy Markdown
Contributor Author
tisonkun commented Dec 1, 2025

@gjenkins8 may you take a look at this PR? It seems another candidate for long pending and finally stale :/

@TerryHowe TerryHowe closed this Dec 13, 2025
@TerryHowe TerryHowe reopened this Dec 13, 2025
@TerryHowe TerryHowe added the Has One Approval This PR has one approval. It still needs a second approval to be merged. label Dec 13, 2025
@tisonkun
Check plugin name is not used
5196b84 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Fix TestCliPluginExitCode
3c6557d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Update to use slog
9772037 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Copy Markdown
Contributor Author
tisonkun commented Dec 17, 2025

Any chance we move this PR forward?

@tisonkun
Copy link
Copy Markdown
Contributor Author
tisonkun commented Jan 9, 2026

cc @banjoh

Sorry to mention more committers but this seems to be stalled without certain new requests.

banjoh
banjoh approved these changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor
@banjoh banjoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banjoh banjoh merged commit 2e2cb05 into helm:main Jan 9, 2026
5 checks passed
@scottrigby scottrigby added bug Categorizes issue or PR as related to a bug. needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. and removed Has One Approval This PR has one approval. It still needs a second approval to be merged. labels Jan 12, 2026
@scottrigby scottrigby added this to the 4.0.5 milestone Jan 12, 2026
@scottrigby scottrigby added picked Indicates that a PR has been cherry-picked into the next release candidate. and removed needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@banjoh banjoh banjoh approved these changes

@robertsirc robertsirc Awaiting requested review from robertsirc

@TerryHowe TerryHowe Awaiting requested review from TerryHowe

@gjenkins8 gjenkins8 Awaiting requested review from gjenkins8

Assignees

No one assigned

Labels

bug Categorizes issue or PR as related to a bug. picked Indicates that a PR has been cherry-picked into the next release candidate. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

4.0.5

Development

Successfully merging this pull request may close these issues.

6 participants

@tisonkun @robertsirc @TerryHowe @banjoh @gjenkins8 @scottrigby
0