Require uwot >= 0.2.1 - #10447
Open
PancakeZoy wants to merge 1 commit into
Open
Conversation
Seurat imports uwot::umap2, which was introduced in uwot 0.2.1. Update the minimum required uwot version so the declared dependency matches the API required by Seurat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the minimum required version of
uwotfrom 0.1.10 to 0.2.1.Type of change
Motivation
Seurat imports
uwot::umap2, butumap2was introduced in uwot 0.2.1. The current dependency declaration (uwot >= 0.1.10) therefore permits versions of uwot that do not exportumap2.This change updates the minimum required uwot version to match the API required by Seurat.
Tests & examples
Not applicable; this is a dependency metadata-only change.