feat: enable native wildcard expansion for CLI on Windows - #284
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Windows command-line shells (cmd.exe, PowerShell) do not expand wildcards like `*.txt` before passing them to an executable, unlike POSIX shells. This means patterns are passed literally, preventing the CLI from processing multiple files via globbing on Windows. This commit links `setargv.obj` to the CLI executable when building with MSVC. This instructs the C runtime (CRT) to perform argument list globbing, allowing patterns to be expanded into individual file paths before `main()` is invoked. A new test verifies that `setargv.obj` correctly expands quoted wildcard patterns when running on Windows, ensuring consistent behavior across platforms.
hellobertrand
force-pushed
the
feat/windows-argv-glob
branch
from
June 15, 2026 11:36
feafd5d to
a0ae94d
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4BCF
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows command-line shells (cmd.exe, PowerShell) do not expand wildcards like
*.txtbefore passing them to an executable, unlike POSIX shells. This means patterns are passed literally, preventing the CLI from processing multiple files via globbing on Windows.This commit links
setargv.objto the CLI executable when building with MSVC. This instructs the C runtime (CRT) to perform argument list globbing, allowing patterns to be expanded into individual file paths beforemain()is invoked.A new test verifies that
setargv.objcorrectly expands quoted wildcard patterns when running on Windows, ensuring consistent behavior across platforms.