fix(cctx): Reset dict_size in compression context - #351
Merged
Conversation
The `zxc_compress_cctx` function now explicitly resets `cctx->inner.dict_size` to `0` to ensure a consistent initial state for every compression operation. This prevents potential issues where a reused context might carry over an incorrect dictionary size from a previous operation. Additionally, the benchmark workflow is updated to clone the official `inikep/lzbench` repository. This ensures that performance benchmarks are conducted against the standard `lzbench` tool, aligning with general development and testing practices.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zxc_compress_cctxfunction now explicitly resetscctx->inner.dict_sizeto0to ensure a consistent initial state for every compression operation. This prevents potential issues where a reused context might carry over an incorrect dictionary size from a previous operation.Additionally, the benchmark workflow is updated to clone the official
inikep/lzbenchrepository. This ensures that performance benchmarks are conducted against the standardlzbenchtool, aligning with general development and testing practices.