8000 8000
Skip to content

fix: wait kc-service valid in workflow#285

Merged
moweiwei merged 1 commit intokubeclipper:masterfrom
cmycoups:master
Nov 23, 2022
Merged

fix: wait kc-service valid in workflow#285
moweiwei merged 1 commit intokubeclipper:masterfrom
cmycoups:master

Conversation

@cmycoups
Copy link
Copy Markdown
Contributor

Signed-off-by: cmyscoups chen.mengyun@99cloud.net

Signed-off-by: cmyscoups chen.mengyun@99cloud.net
@kubeclipper-bot
Copy link
Copy Markdown
Collaborator

@cmycoups: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2022
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #285 (16e5f3b) into master (1554505) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   46.41%   46.41%           
=======================================
  Files           7        7           
  Lines         614      614           
  Branches      177      177           
=======================================
  Hits          285      285           
  Misses        254      254           
  Partials       75       75           

Copy link
Copy Markdown
Collaborator
@moweiwei moweiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@kubeclipper-bot
Copy link
Copy Markdown
Collaborator

LGTM label has been added.

DetailsGit tree hash: b551a826264411faf4704bdc5ec79df0aec5cbfb

@kubeclipper-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cmycoups, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@moweiwei
Copy link
Copy Markdown
Collaborator

/cherrypick release-1.3

@kubeclipper-bot
Copy link
Copy Markdown
Collaborator

@moweiwei: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot
Copy link
Copy Markdown
Collaborator

@moweiwei: new pull request created: #290

Details

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

moweiwei pushed a commit to moweiwei/console that referenced this pull request Jan 5, 2023
Signed-off-by: cmyscoups chen.mengyun@99cloud.net

Signed-off-by: cmyscoups chen.mengyun@99cloud.net
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0