8000 7FFF
Skip to content

fix: remove errorbounadry outside router#261

Merged
kubeclipper-bot merged 1 commit intokubeclipper:masterfrom
moweiwei:master
Nov 17, 2022
Merged

fix: remove errorbounadry outside router#261
kubeclipper-bot merged 1 commit intokubeclipper:masterfrom
moweiwei:master

Conversation

@moweiwei
Copy link
Copy Markdown
Collaborator
@moweiwei moweiwei commented Nov 17, 2022

Signed-off-by: moweiwei mo.weiwei@99cloud.net

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

@moweiwei
fix: remove errorbounadry outside router
73de3dc 
Signed-off-by: moweiwei <mo.weiwei@99cloud.net>
@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Nov 17, 2022

@moweiwei: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2022
@codecov-commenter
Copy link
Copy Markdown
codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #261 (73de3dc) into master (be23a7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   46.41%   46.41%           
=======================================
  Files           7        7           
  Lines         614      614           
  Branches      177      177           
=======================================
  Hits          285      285           
  Misses        254      254           
  Partials       75       75

@moweiwei
Copy link
Copy Markdown
Collaborator Author
moweiwei commented Nov 17, 2022

/cherrypick release-1.3

@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Nov 17, 2022

@moweiwei: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lysign
Copy link
Copy Markdown
Collaborator
lysign commented Nov 17, 2022

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2022
@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Nov 17, 2022

LGTM label has been added.

DetailsGit tree hash: ff6e6c45333ccecea5f624d7a1affdaed2f89d6b

@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Nov 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lysign, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot merged commit c56e1a8 into kubeclipper:master Nov 17, 2022
@kubeclipper-bot kubeclipper-bot mentioned this pull request Nov 17, 2022
Merged
@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Nov 17, 2022

@moweiwei: new pull request created: #263

Details

In response to this:

/cherrypick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

moweiwei added a commit to moweiwei/console that referenced this pull request Jan 5, 2023
@moweiwei
fix: remove errorbounadry outside router (kubeclipper#261)
fc1a032 
Signed-off-by: moweiwei <mo.weiwei@99cloud.net>

Signed-off-by: moweiwei <mo.weiwei@99cloud.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lysign lysign

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@moweiwei @kubeclipper-bot @codecov-commenter @lysign
0