8000
Skip to content

fix: terminal port can not string#216

Merged
kubeclipper-bot merged 1 commit intokubeclipper:masterfrom
lysign:master
Oct 20, 2022
Merged

fix: terminal port can not string#216
kubeclipper-bot merged 1 commit intokubeclipper:masterfrom
lysign:master

Conversation

@lysign
Copy link
Copy Markdown
Collaborator
@lysign lysign commented Oct 20, 2022

Signed-off-by: liuying liu.ying@99cloud.net

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Additional documentation, usage docs, etc.:

@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Oct 20, 2022

@lysign: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeclipper-bot kubeclipper-bot added dco-signoff: yes do-not-merge/release-note-label-needed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2022
@codecov-commenter
Copy link
Copy Markdown
codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #216 (4dbc40e) into master (bd8c78d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #216   +/-   ##
=======================================
  Coverage   46.82%   46.82%           
=======================================
  Files           7        7           
  Lines         598      598           
  Branches      168      168           
=======================================
  Hits          280      280           
  Misses        245      245           
  Partials       73       73

@lysign
fix: terminal port can not string
891c01f 
Signed-off-by: liuying <liu.ying@99cloud.net>
moweiwei
moweiwei reviewed Oct 20, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator
@moweiwei moweiwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubeclipper-bot kubeclipper-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2022
@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Oct 20, 2022

LGTM label has been added.

DetailsGit tree hash: c63ee2c04059139e004a6361671e7eacbed4c503

@kubeclipper-bot
Copy link
Copy Markdown
Collaborator
kubeclipper-bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lysign, moweiwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeclipper-bot kubeclipper-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@kubeclipper-bot kubeclipper-bot merged commit 4147299 into kubeclipper:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moweiwei moweiwei moweiwei left review comments

Assignees

@moweiwei moweiwei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes do-not-merge/release-note-label-needed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lysign @kubeclipper-bot @codecov-commenter @moweiwei
0