add some conversion tool towards the sagemath package Zeta#21
Open
fchapoton wants to merge 4 commits intolatte-int:masterfrom
Open
add some conversion tool towards the sagemath package Zeta#21fchapoton wants to merge 4 commits intolatte-int:masterfrom
fchapoton wants to merge 4 commits intolatte-int:masterfrom
Conversation
Contributor
|
Supporting other output formats (... in addition to the maple format, not replacing it, obviously) is certainly a good feature to add. This patch does not seem to be complete though. If a better version is prepared, I will be happy to merge it. I hope to prepare a new release of LattE some time this Fall, to be ready for the Sage 9.3 release. |
replacing "maple" by "sagemath"
replace "maple" by "sagemath"
typo
Contributor
Author
|
I have cleaned up a little bit. Do you see something else to do ? Should we care about not having the same function names in two different files ? I have essentially zero knowledge of c++. |
Contributor
Author
|
what makes you say that this is incomplete ? |
Contributor
Two files are added to the source tree, but they are not used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the sagemath package Zeta (http://www.maths.nuigalway.ie/~rossmann/Zeta/) is monkey-patching Latte to use some Latte results in sagemath. Here is a proposal to integrate what they use for the conversion, which is just a modification of the maple conversion tool.
Maybe there are better solutions.