8000
Skip to content

Add support for ROCm 7.2 #18730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliermarsh merged 3 commits into from
Mar 26, 2026
+46 −1
Merged

Add support for ROCm 7.2 #18730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0341cf6
Add support for ROCm 7.2
TwelveNights Mar 26, 2026
13fde28
Apply suggestion from @charliermarsh
charliermarsh Mar 26, 2026
3a6a963
Update schema
charliermarsh Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions crates/uv-torch/src/accelerator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,8 @@ pub enum AmdGpuArchitecture {
Gfx1100,
Gfx1101,
Gfx1102,
Gfx1150,
Gfx1151,
Gfx1200,
Gfx1201,
}
Expand All @@ -314,6 +316,8 @@ impl FromStr for AmdGpuArchitecture {
10BC0 "gfx1100" => Ok(Self::Gfx1100),
"gfx1101" => Ok(Self::Gfx1101),
"gfx1102" => Ok(Self::Gfx1102),
"gfx1150" => Ok(Self::Gfx1150),
"gfx1151" => Ok(Self::Gfx1151),
"gfx1200" => Ok(Self::Gfx1200),
"gfx1201" => Ok(Self::Gfx1201),
_ => Err(AcceleratorError::UnknownAmdGpuArchitecture(s.to_string())),
Expand All @@ -334,6 +338,8 @@ impl std::fmt::Display for AmdGpuArchitecture {
Self::Gfx1100 => write!(f, "gfx1100"),
Self::Gfx1101 => write!(f, "gfx1101"),
Self::Gfx1102 => write!(f, "gfx1102"),
Self::Gfx1150 => write!(f, "gfx1150"),
Self::Gfx1151 => write!(f, "gfx1151"),
Self::Gfx1200 => write!(f, "gfx1200"),
Self::Gfx1201 => write!(f, "gfx1201"),
}
Expand Down
36 changes: 35 additions & 1 deletion crates/uv-torch/src/backend.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ pub enum TorchMode {
Cu90,
/// Use the PyTorch index for CUDA 8.0.
Cu80,
/// Use the PyTorch index for ROCm 7.2.
#[serde(rename = "rocm7.2")]
#[cfg_attr(feature = "clap", clap(name = "rocm7.2"))]
Rocm72,
/// Use the PyTorch index for ROCm 7.1.
#[serde(rename = "rocm7.1")]
#[cfg_attr(feature = "clap", clap(name = "rocm7.1"))]
Expand Down Expand Up @@ -284,6 +288,7 @@ impl TorchStrategy {
TorchMode::Cu91 => TorchBackend::Cu91,
TorchMode::Cu90 => TorchBackend::Cu90,
TorchMode::Cu80 => TorchBackend::Cu80,
TorchMode::Rocm72 => TorchBackend::Rocm72,
TorchMode::Rocm71 => TorchBackend::Rocm71,
TorchMode::Rocm70 => TorchBackend::Rocm70,
TorchMode::Rocm64 => TorchBackend::Rocm64,
Expand Down Expand Up @@ -551,6 +556,7 @@ pub enum TorchBackend {
Cu91,
Cu90,
Cu80,
Rocm72,
Rocm71,
Rocm70,
Rocm64,
Expand Down Expand Up @@ -685,6 +691,10 @@ impl TorchBackend {
TorchSource::PyTorch => &PYTORCH_CU80_INDEX_URL,
TorchSource::Pyx => &PYX_CU80_INDEX_URL,
},
Self::Rocm72 => match source {
TorchSource::PyTorch => &PYTORCH_ROCM72_INDEX_URL,
TorchSource::Pyx => &PYX_ROCM72_INDEX_URL,
},
Self::Rocm71 => match source {
TorchSource::PyTorch => &PYTORCH_ROCM71_INDEX_URL,
TorchSource::Pyx => &PYX_ROCM71_INDEX_URL,
Expand Down Expand Up @@ -824,6 +834,7 @@ impl TorchBackend {
Self::Cu91 => Some(Version::new([9, 1])),
Self::Cu90 => Some(Version::new([9, 0])),
Self::Cu80 => Some(Version::new([8, 0])),
Self::Rocm72 => None,
Self::Rocm71 => None,
Self::Rocm70 => None,
Self::Rocm64 => None,
Expand Down Expand Up @@ -877,6 +888,7 @@ impl TorchBackend {
Self::Cu91 => None,
Self::Cu90 => None,
Self::Cu80 => None,
Self::Rocm72 => Some(Version::new([7, 2])),
Self::Rocm71 => Some(Version::new([7, 1])),
Self::Rocm70 => Some(Version::new([7, 0])),
Self::Rocm64 => Some(Version::new([6, 4])),
Expand Down Expand Up @@ -933,6 +945,7 @@ impl FromStr for TorchBackend {
"cu91" => Ok(Self::Cu91),
"cu90" => Ok(Self::Cu90),
"cu80" => Ok(Self::Cu80),
"rocm7.2" => Ok(Self::Rocm72),
"rocm7.1" => Ok(Self::Rocm71),
"rocm7.0" => Ok(Self::Rocm70),
"rocm6.4" => Ok(Self::Rocm64),
Expand Down Expand Up @@ -1050,9 +1063,24 @@ static WINDOWS_CUDA_VERSIONS: LazyLock<[(TorchBackend, Version); 26]> = LazyLock
///
/// AMD also provides a compatibility matrix: <https://rocm.docs.amd.com/en/latest/compatibility/compatibility-matrix.html>;
/// however, this list includes a broader array of GPUs than those in the matrix.
static LINUX_AMD_GPU_DRIVERS: LazyLock<[(TorchBackend, AmdGpuArchitecture); 79]> =
static LINUX_AMD_GPU_DRIVERS: LazyLock<[(TorchBackend, AmdGpuArchitecture); 93]> =
LazyLock::new(|| {
[
// ROCm 7.2
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx900),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx906),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx908),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx90a),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx942),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx950),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1030),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1100),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1101),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1102),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1150),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1151),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1200),
(TorchBackend::Rocm72, AmdGpuArchitecture::Gfx1201),
// ROCm 7.1
(TorchBackend::Rocm71, AmdGpuArchitecture::Gfx900),
(TorchBackend::Rocm71, AmdGpuArchitecture::Gfx906),
Expand Down Expand Up @@ -1197,6 +1225,8 @@ static PYTORCH_CU90_INDEX_URL: LazyLock<IndexUrl> =
LazyLock::new(|| IndexUrl::from_str("https://download.pytorch.org/whl/cu90").unwrap());
static PYTORCH_CU80_INDEX_URL: LazyLock<IndexUrl> =
LazyLock::new(|| IndexUrl::from_str("https://download.pytorch.org/whl/cu80").unwrap());
static PYTORCH_ROCM72_INDEX_URL: LazyLock<IndexUrl> =
LazyLock::new(|| IndexUrl::from_str("https://download.pytorch.org/whl/rocm7.2").unwrap());
static PYTORCH_ROCM71_INDEX_URL: LazyLock<IndexUrl> =
LazyLock::new(|| IndexUrl::from_str("https://download.pytorch.org/whl/rocm7.1").unwrap());
static PYTORCH_ROCM70_INDEX_URL: LazyLock<IndexUrl> =
Expand Down Expand Up @@ -1351,6 +1381,10 @@ static PYX_CU80_INDEX_URL: LazyLock<IndexUrl> = LazyLock::new(|| {
let api_base_url = &*PYX_API_BASE_URL;
IndexUrl::from_str(&format!("{api_base_url}/simple/astral-sh/cu80")).unwrap()
});
static PYX_ROCM72_INDEX_URL: LazyLock<IndexUrl> = LazyLock::new(|| {
let api_base_url = &*PYX_API_BASE_URL;
IndexUrl::from_str(&format!("{api_base_url}/simple/astral-sh/rocm7.2")).unwrap()
});
static PYX_ROCM71_INDEX_URL: LazyLock<IndexUrl> = LazyLock::new(|| {
let api_base_url = &*PYX_API_BASE_URL;
IndexUrl::from_str(&format!("{api_base_url}/simple/astral-sh/rocm7.1")).unwrap()
Expand Down
5 changes: 5 additions & 0 deletions uv.schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
0