Merge repeated archive URL hashes by version ID#18841
Open
charliermarsh wants to merge 1 commit intocharlie/merge-hashes-ifrom
Open
Merge repeated archive URL hashes by version ID#18841charliermarsh wants to merge 1 commit intocharlie/merge-hashes-ifrom
charliermarsh wants to merge 1 commit intocharlie/merge-hashes-ifrom
Conversation
ac75c97 to
23d233d
Compare
23d233d to
06df5b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If we encounter multiple hashes for the same direct URL, we now (1) reject if they use the same algorithm but different values, and (2) collect if they use different algorithms. This includes cases in which a user provides both a hash in the fragment and via
--hash.For now, if any hash is correct, the URL will be accepted; we'll change this in the future. (On main, we only consider the last-seen hash anyway.)