8000
Skip to content

feat: toast组件props补齐+国际化,input组件issue问题修改#214

Merged
oasis-cloud merged 4 commits intojdf2e:mainfrom
vickyYE:main
Aug 19, 2022
Merged

feat: toast组件props补齐+国际化,input组件issue问题修改#214
oasis-cloud merged 4 commits intojdf2e:mainfrom
vickyYE:main

Conversation

@vickyYE
Copy link
Copy Markdown
Contributor
@vickyYE vickyYE commented Aug 11, 2022

feat: toast组件props补齐+国际化,input组件issue问题修改

Copy link
Copy Markdown
Collaborator
@oasis-cloud oasis-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充新增 props 的测试用例

Comment thread src/packages/toast/Notification.tsx Outdated
this.clickCover = this.clickCover.bind(this)
}

// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, react/sort-comp
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉 eslint 的注释

Comment thread src/packages/toast/Notification.tsx Outdated
@@ -1,3 +1,4 @@
/* eslint-disable react/no-unused-prop-types */
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去掉 eslint 的注释

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0