Merged
Conversation
oasis-cloud
reviewed
Jul 26, 2022
| } | ||
| const rootRef = useRef<HTMLVideoElement>(null) | ||
|
|
||
| useEffect(() => { |
| if (options.playsinline) { | ||
| videoRef.setAttribute( | ||
| 'playsinline', | ||
| JSON.stringify(options.playsinline) |
| @@ -0,0 +1,19 @@ | |||
| .demo { | |||
Collaborator
There was a problem hiding this comment.
可采用 demo-video 来命名，demo的打包没有采用module css
yangjinjun3
suggested changes
Jul 29, 2022
| | 字段 | 说明 | 类型 | 默认值 | | ||
| | ------------------- | ------------------------------------------ | ------- | -------- | | ||
| | source | 视频地址和类型设置 | Object | - | | ||
| | options | 控制视频播放属性 | Object | required | |
| | options.loop | 是否循环播放 | Boolean | false | | ||
| | options.controls | 是否展示操作栏 | Boolean | true | | ||
| | options.muted | 是否静音 | Boolean | false | | ||
| | options.disabled | 禁用操作（如循环播放的背景图，禁止操作） | Boolean | false | |
Contributor
There was a problem hiding this comment.
disabled 的作用是啥？ 感觉加不加效果一样
| poster: '', | ||
| playsinline: false, | ||
| disabled: false, | ||
| loop: false, |
Contributor
There was a problem hiding this comment.
我看Vue版本有touchPlay: false,preload: ''这两个默认值，确认下React是否需要加？
oasis-cloud
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.video视频组件开发
2.单元测试开发检测
3.demo多语言支持
4.文档多语言支持