8000
Skip to content

fix: rely on AWS SDK error propagation for missing credentials #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mkubaczyk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: rely on AWS SDK error propagation for missing credentials #987

mkubaczyk wants to merge 1 commit into from

Conversation

@mkubaczyk
Copy link
Owner
@mkubaczyk mkubaczyk commented Dec 19, 2025

Should fix #975

I think we can rely on error propagation from AWS SDK instead of upfront requirements check, see https://pkg.go.dev/github.com/aws/aws-sdk-go/aws/credentials#pkg-variables ErrNoValidProvidersFoundInChain.
Added simple test to make sure any error is propagated to cover this case.

@mkubaczyk mkubaczyk marked this pull request as ready for review December 19, 2025 15:50
@mkubaczyk mkubaczyk requested a review from luisdavim December 19, 2025 15:50
@mkubaczyk mkubaczyk mentioned this pull request Dec 19, 2025
Open
luisdavim
luisdavim approved these changes Dec 19, 2025
View reviewed changes
Copy link
Collaborator
@luisdavim luisdavim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luisdavim luisdavim luisdavim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent lack of AWS_* explicit session variables from generating warnings

3 participants

@mkubaczyk @luisdavim
0