8000
Skip to content

Add *ln variants of methods to the SugaredLogger#1080

Merged
abhinav merged 3 commits intouber-go:masterfrom
zhupeijun:feature/add_ln_methods_to_sugarlogger
Apr 12, 2022
Merged

Add *ln variants of methods to the SugaredLogger#1080
abhinav merged 3 commits intouber-go:masterfrom
zhupeijun:feature/add_ln_methods_to_sugarlogger

Conversation

@zhupeijun
Copy link
Copy Markdown
Contributor
@zhupeijun zhupeijun commented Apr 11, 2022

Currently zap sugared logger dose not have method like fmt.Println, this PR adding *ln variants of methods to SugaredLogger.

zap.S().Info("a", "b")
zap.S().Infoln("a", "b")
fmt.Println("a", "b")

zap Info output: ab
zap Infoln output: a b
fmt output: a b

Related issue: #889

@CLAassistant
Copy link
Copy Markdown
CLAassistant commented Apr 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
8000
Copy link
Copy Markdown
codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #1080 (b20afd6) into master (1d435ba) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
+ Coverage   98.30%   98.31%   +0.01%     
==========================================
  Files          49       49              
  Lines        2123     2137      +14     
==========================================
+ Hits         2087     2101      +14     
  Misses         28       28              
  Partials        8        8
Impacted Files Coverage Δ
sugar.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d435ba...b20afd6. Read the comment docs.

@zhupeijun zhupeijun force-pushed the feature/add_ln_methods_to_sugarlogger branch 2 times, most recently from 59f6c9d to e013d3b Compare April 12, 2022 01:24
@zhupeijun zhupeijun force-pushed the feature/add_ln_methods_to_sugarlogger branch from e013d3b to 0f22697 Compare April 12, 2022 01:58
abhinav
abhinav approved these changes Apr 12, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator
@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhinav abhinav merged commit d38507c into uber-go:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinav abhinav abhinav approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhupeijun @CLAassistant @abhinav
0