8000
Skip to content

Improve GNSS output: add selectable output mode #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mackierx111 merged 5 commits into from
Oct 17, 2025
Merged

Improve GNSS output: add selectable output mode #450

mackierx111 merged 5 commits into from
Oct 17, 2025

Conversation

@zzhhaa10000
Copy link
Contributor
@zzhhaa10000 zzhhaa10000 commented Oct 16, 2025

Checklist before requesting a review

  • Follow coding standards.
  • Follow AWSIM architecture.
  • No unnecessary comments or Debug.Log() remain.
  • The latest main branch has been merged into the work branch.
  • The expected behavior is achieved after implementation. Furthermore, existing functions are not affected.
  • Understand AWSIM License and agree that it applies to this contribution.

Description

This pull request improves the GNSS output functionality.
It adds a new option that allows users to select the output format between MGRS and NavSatFix.

Main Changes

  • Added OutputMode parameter to GnssSensor for selecting output format
  • Updated GnssRos2Publisher to handle both MGRS and NavSatFix message types
  • Verified correct behavior in both modes within AWSIM–Autoware integration

mackierx111
mackierx111 approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator
@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackierx111 mackierx111 merged commit 977b897 into main Oct 17, 2025
@mackierx111 mackierx111 deleted the feature/improve-gnss-output branch October 17, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zzhhaa10000 @mackierx111
0