8000
Skip to content

docs: popup-image tag #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mackierx111 merged 2 commits into from
Oct 8, 2025
Merged

docs: popup-image tag #444

mackierx111 merged 2 commits into from
Oct 8, 2025

Conversation

@rokamu623
Copy link
Contributor
@rokamu623 rokamu623 commented Sep 29, 2025

Checklist before requesting a review

  • Follow coding standards.
  • Follow AWSIM architecture.
  • No unnecessary comments or Debug.Log() remain.
  • The latest main branch has been merged into the work branch.
  • The expected behavior is achieved after implementation. Furthermore, existing functions are not affected.
  • Understand AWSIM License and agree that it applies to this contribution.

Feature

Define custom-tag and adopt this tag to documents.

<a href="[path]" data-lightbox="[text]" data-title="" data-alt="[text]"><img src="[path]"></a> // not using custom-tag
<popup-img src="[path]" alt="[text]"></popup-img> // using custom-tag

@rokamu623 rokamu623 self-assigned this Sep 29, 2025
@rokamu623 rokamu623 added the documentation Improvements or additions to documentation label Sep 29, 2025
mackierx111
mackierx111 approved these changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator
@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackierx111 mackierx111 merged commit d147668 into main Oct 8, 2025
@mackierx111 mackierx111 deleted the docs/popupimage_tag branch October 8, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees

@rokamu623 rokamu623

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rokamu623 @mackierx111
0