Adds optional msgpack serialization format to Rabl.#69
Merged
nesquena merged 1 commit intonesquena:masterfrom Sep 2, 2011
byu:feature/msgpack
Merged
Adds optional msgpack serialization format to Rabl.#69nesquena merged 1 commit intonesquena:masterfrom byu:feature/msgpack
nesquena merged 1 commit intonesquena:masterfrom
byu:feature/msgpack
Conversation
Details * Fixes #68 (nesquena/rabl issues tracker) * Message Pack: http://www.msgpack.org/ * Defaults to using the Ruby msgpack gem: http://rubygems.org/gems/msgpack * Adds Rabl configuration option `include_msgpack_root` which has same semantics as include_json_root. * Adds Rabl configuration option `msgpack_engine` which has similar semantics as json_engine. * Adds whole test suite that is essentially a clone of engine_test.rb, but with proper msgpack expected values. Note that I converted the JSON expected values to their msgpack equivalent in this process. * Updated README.md to reflect the msgpack changes.
Owner
|
Thanks will review and merge this in soon! |
Owner
|
@byu Thanks for contributing this! Finally merging now |
nesquena
added a commit
that referenced
this pull request
Sep 2, 2011
Adds optional msgpack serialization format to Rabl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
include_msgpack_rootwhich has same semantics as include_json_root.msgpack_enginewhich has similar semantics as json_engine.Note that I converted the JSON expected values to their msgpack equivalent in this process.