[ie/RTP] Fix subtitle extraction in RTP extractor#16361
Open
red-acid wants to merge 1 commit intoyt-dlp:masterfrom
Open
[ie/RTP] Fix subtitle extraction in RTP extractor#16361red-acid wants to merge 1 commit intoyt-dlp:masterfrom
red-acid wants to merge 1 commit intoyt-dlp:masterfrom
Conversation
8 tasks
Contributor
Author
|
@bashonly please review so we can squash the last outstanding extractor issue. Thank you! |
Updated subtitle extraction logic to retrieve them from `asset_data` instead of `asset_urls` on main `_extract_from_api`, and fixed extraction on the fallback `_extract_from_html`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your pull request and other information
Based on the previous changes included in #13625, this PR fixes the subtitle extraction logic:
asset_datafield instead ofasset_urlsin the main_extract_from_api_extract_from_htmlTemplate
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check those that apply and remove the others:
What is the purpose of your pull request? Check those that apply and remove the others: