Closed
Conversation
This makes it much nicer for anyone using Docker to download an archive using `ADD`. See the documentation: https://docs.docker.com/reference/dockerfile/#add---checksum Also, anyone else who needs to verify the built file doesn't need to download it, then generate their own checksum.
If sums are completed in under 15 seconds, then we wait on sleep. Otherwise, we wait for sums to finish.
Prevent nullglob from causing sums to wait on input from stdin.
nullglob causes arguments to disappear entirely rather than failing to open non-existent files. cat without arguments will wait for input from stdin, which won't be coming. This would leave the step hung.
e480883 to
6957a1c
Compare
Collaborator
|
I'll keep the upstream implementation. Having multiple hash algorithms is not particularly useful. Hashing doesn't slow the build enough to warrant spreading the computation to multiple runners either. |
Author
I have to disagree with that statement. Having the option to use a better hash (for collisions or a supporting a particular tool or whatever) already available is very useful. |
Collaborator
|
Collisions aren't of particular concern for download verification. Everything works with SHA256. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream has added
checksums.sha256(which we hope works) but I like this better because it spreads the task of computing sums to the job runners, and provides all the sha algorithm sums in a format that's easy to grep the algorithm and/or file that you want to use from theSUMSfile.This is a follow up from: #69