Fix CLI parser to ensure project file check only applies to non-option arguments#118683
Open
nikitalita wants to merge 1 commit intogodotengine:masterfrom
Open
Fix CLI parser to ensure project file check only applies to non-option arguments#118683nikitalita wants to merge 1 commit intogodotengine:masterfrom
nikitalita wants to merge 1 commit intogodotengine:masterfrom
Conversation
… non-option arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To re
6A28
view, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user-defined CLI flag takes in a parameter, and that parameter just so happens to end in
project.godot(e.g.--txt-to-bin=/path/to/project.godot), the CLI parser currently interprets that as a request to load that project.Changing it such that it only applies to non-option arguments (i.e. it doesn't begin with
--) fixes the issue.