Add fujifilm camera support#2
Merged
ganeshrvel merged 1 commit intoganeshrvel:fix/garmin-fujifilmfrom Nov 1, 2022
Merged
Conversation
Fujifilm cameras, like Windows Phone 8 devices, don't send an InterfaceStringIndex. This patch adds a similar exception to Open() to handle those cameras.
Owner
|
Thank you for the PRs. Merged them. Shall be releasing a beta release of OpenMTP tonight |
Owner
|
Hey @CodyJung, Thanks a tonne for your PRs. I have made a release tonight. Please download the DMG file from the appropriate URL given below and do let me know if the Garmin and Fujifilm devices work on OpenMTP. Thanks again! OpenMTP-3.2.0-beta.1 is out 🔥🔥 Note: This a pre-release version and the app might be unstable. Features
DownloadmacOS Apple Silicone (arm64): https://github.com/ganeshrvel/openmtp/releases/download/v3.2.0-beta.1/openmtp-3.2.0-beta.1-mac-arm64.dmg |
This was referenced Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fujifilm cameras, like Windows Phone 8 devices, don't send an InterfaceStringIndex.
This patch adds a similar exception to Open() to handle those cameras.
In the future, we want to make this more generic, depending on the number of devices this applies to.
Should help ganeshrvel/openmtp#259
Edit: removed the fixed keyword so that issue doesn’t get auto-closed