Merged
Conversation
fh-ms
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Vaadin framework version and introduces a new
AppShellclass to manage global UI configuration for the client app. It also refactors theRootLayoutclass to remove UI configuration annotations, delegating them to the newAppShell.Framework and dependency updates:
24.2.6to24.8.10in the Maven project configuration to ensure access to the latest features and fixes.UI configuration refactoring:
AppShellclass that implementsAppShellConfiguratorand applies global UI settings, such as enabling push support, setting the Lumo dark theme, and importing shared CSS styles.@Push,@Theme,@CssImport) from theRootLayoutclass, so that these settings are now centralized in the newAppShell.