Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/a7819c15-7724-4894-bff0-fdd691a7147e Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Hey A couple of things worth addressing before this moves out of draft:
If you'd like a hand getting test coverage in place, here's a prompt you can assign to your coding agent:
|
There was a problem hiding this comment.
Pull request overview
This PR wires up missing SEO/discovery assets for the Astro-based docs site by explicitly enabling sitemap generation and making RSS/sitemap dependencies explicit.
Changes:
- Register
@astrojs/sitemapinastro.config.mjsintegrations sositemap-index.xmlis emitted at build time. - Add
@astrojs/sitemapand@astrojs/rssas direct dependencies inpackage.json. - Update
package-lock.jsonto reflect the new direct dependency declarations.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/astro.config.mjs | Imports and registers the sitemap integration to generate the sitemap index during builds. |
| docs/package.json | Declares @astrojs/rss and @astrojs/sitemap as direct dependencies for explicit/robust installs. |
| docs/package-lock.json | Records the dependency spec additions at the workspace root. |
Files not reviewed (1)
- docs/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The docs site was missing two generated assets —
sitemap-index.xml(referenced in HTML head for SEO) andblog/rss.xml(linked from blog nav) — because neither integration was wired up.Changes
astro.config.mjs: Import and register@astrojs/sitemapin theintegrationsarray; Astro will now emit/gh-aw/sitemap-index.xmlat build timepackage.json: Add@astrojs/sitemapand@astrojs/rssas explicit direct dependenciesBoth packages were already present in
package-lock.jsonas transitive deps (@astrojs/starlight→@astrojs/sitemap,starlight-blog→@astrojs/rss), so no new packages are introduced — the RSS feed was already being generated bystarlight-blogbut the dependency was implicit.