-
Notifications
You must be signed in to change notification settings - Fork 325
[WIP] Fix daily mcp concurrency analysis by adding jq and git log to bash allowlist #23886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -37,11 +37,14 @@ tools: | |||||||||||||
| edit: | ||||||||||||||
| bash: | ||||||||||||||
| - "cat pkg/workflow/js/safe_outputs_tools.json" | ||||||||||||||
| - "jq -r '.[].name' pkg/workflow/js/safe_outputs_tools.json" | ||||||||||||||
| - "find actions/setup/js -name '*.cjs' ! -name '*.test.cjs' -type f" | ||||||||||||||
| - "cat actions/setup/js/*.cjs" | ||||||||||||||
| - "grep -r 'let \\|var \\|const ' actions/setup/js --include='*.cjs'" | ||||||||||||||
| - "grep -r 'module.exports' actions/setup/js --include='*.cjs'" | ||||||||||||||
| - "head -n * actions/setup/js/*.cjs" | ||||||||||||||
| - "git log -1 --format='%ai' -- actions/setup/js/*.cjs" | ||||||||||||||
| - "git log -3 --format='%ai %s' -- actions/setup/js/*.cjs" | ||||||||||||||
|
Comment on lines
+46
to
+47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The allowlisted
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| timeout-minutes: 45 | ||||||||||||||
| strict: true | ||||||||||||||
|
|
||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow instructions later recommend running
cat pkg/workflow/js/safe_outputs_tools.json | jq -r '.[].name' | sort, but the bash allowlist here only permitscat ...,jq -r '.[].name' pkg/..., andsortas separate commands (a piped command likely won’t match the allowlist). Consider updating the instructions to use the allowlisted standalonejq ... file | sort(or explicitly allow the piped form) so the agent doesn’t get blocked following the documented steps.