Fix wasm golden tests and lint error after mcpg version bump to v0.1.14#20588
Merged
Fix wasm golden tests and lint error after mcpg version bump to v0.1.14#20588
Conversation
…ror S1021 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates wasm golden fixtures and an example workflow lock file to match the bumped MCP Gateway image version (v0.1.14), and resolves a staticcheck warning in a workflow compiler test.
Changes:
- Updated
ghcr.io/github/gh-aw-mcpgimage references in wasm golden fixtures fromv0.1.8tov0.1.14. - Updated the same MCP Gateway image reference in
example-blocked-domains.lock.ymlfor consistency. - Simplified compiler initialization in
compiler_orchestrator_engine_test.goto fixS1021.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/with-imports.golden | Updates MCP Gateway image tag in golden fixture output. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/smoke-copilot.golden | Updates MCP Gateway image tag in golden fixture output. |
| pkg/workflow/testdata/wasm_golden/TestWasmGolden_CompileFixtures/basic-copilot.golden | Updates MCP Gateway image tag in golden fixture output. |
| pkg/workflow/compiler_orchestrator_engine_test.go | Refactors compiler initialization to satisfy staticcheck (S1021). |
| pkg/cli/workflows/example-blocked-domains.lock.yml | Updates MCP Gateway image tag in the checked-in lock file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three wasm golden test fixtures and a lock file were still referencing the old MCP gateway image version (
v0.1.8) afterDefaultMCPGatewayVersionwas bumped tov0.1.14, causing golden comparison failures. A separate staticcheck lint error (S1021) was also introduced in a test file.Changes
basic-copilot,smoke-copilot,with-imports): Updatedghcr.io/github/gh-aw-mcpg:v0.1.8→v0.1.14to match currentDefaultMCPGatewayVersionexample-blocked-domains.lock.yml: Same version update for consistencycompiler_orchestrator_engine_test.go:192: Merged splitvar/assignment intocompiler := NewCompiler()to resolveS1021staticcheck warning