[Navigation] update KotlinPoet to 1.8.0 for navigation safe-args - #172
Closed
tatocaster wants to merge 2 commits into
Closed
[Navigation] update KotlinPoet to 1.8.0 for navigation safe-args#172tatocaster wants to merge 2 commits into
tatocaster wants to merge 2 commits into
Conversation
Contributor
Author
|
except the PR, const val KOTLINPOET = "com.squareup:kotlinpoet:1.4.0"
const val KOTLINPOET_METADATA = "com.squareup:kotlinpoet-metadata:1.4.0"
const val KOTLINPOET_METADATA_SPECS = "com.squareup:kotlinpoet-metadata-specs:1.4.0"
const val KOTLINPOET_CLASSINSPECTOR_ELEMENTS = "com.squareup:kotlinpoet-classinspector-elements:1.4.0"Those properties are not used anywhere. I guess we can safely remove |
ianhanniballake
requested changes
May 3, 2021
Member
There was a problem hiding this comment.
As part of this, can you please remove the unused dependencies:
const val KOTLINPOET_METADATA = "com.squareup:kotlinpoet-metadata:1.4.0"
const val KOTLINPOET_METADATA_SPECS = "com.squareup:kotlinpoet-metadata-specs:1.4.0"
const val KOTLINPOET_CLASSINSPECTOR_ELEMENTS = "com.squareup:kotlinpoet-classinspector-elements:1.4.0"
|
|
||
| implementation(JAVAPOET) | ||
| implementation("com.squareup:kotlinpoet:1.7.2") | ||
| implementation("com.squareup:kotlinpoet:1.8.0") |
Member
There was a problem hiding this comment.
Use the KOTLINPOET variable here and update the value there.
ianhanniballake
approved these changes
May 3, 2021
Member
|
Thanks for the pull request! |
harryzz
pushed a commit
to harryzz/compose-multiplatform-core
that referenced
this pull request
Jul 28, 2026
## Proposed Changes Update KotlinPoet to 1.8.0 for navigation safe-args. ## Testing Test: ./gradlew test ## Issues Fixed Fixes: The bug on [https://issuetracker.google.com/issues/183990444](https://issuetracker.google.com/issues/183990444) being fixed This is an imported pull request from androidx#172. Resolves JetBrains#172 Github-Pr-Head-Sha: 9d76723 GitOrigin-RevId: 00e43c6 Change-Id: Id03891bbf11821786236a3dab35042123035ba12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Update KotlinPoet to 1.8.0 for navigation safe-args.
Testing
Test: ./gradlew test
Issues Fixed
Fixes: The bug on https://issuetracker.google.com/issues/183990444 being fixed