SRTRestream #7003
SRTRestream #7003
Conversation
596dfa5 to
5fe73d5
Compare
5fe73d5 to
61fbde6
Compare
69b13e7 to
00054d0
Compare
782b9bf to
47546ec
Compare
47546ec to
bdab45b
Compare
|
There was a problem hiding this comment.
Hi @USAMAWIZARD
Thank you for the implementation.
I have some change requests and added comments.
Let me know if you have further questions
Regards
|
|
||
| boolean result = super.addVideoStream(width, height, timebase, codecId, streamIndex, isAVC, codecpar); | ||
| if (result) | ||
|
if (result && !this |
There was a problem hiding this comment.
I think positive statement is more meaningful.
I mean run this line if it is flv because we are doing something specific related to the flv or rtmp
| String rtmpUrl = null; | ||
| return addEndpointV4(id,endpoint,resolutionHeight); | ||
| } | ||
| @POST |
There was a problem hiding this comment.
Please add documentation with openapi annodations. Keep in mind that developers uses these references. So please give the enough information to make life easy for developers.
| @Produces(MediaType.APPLICATION_JSON) | ||
| public Result addEndpointV4(@Parameter(description = "Broadcast id", required = true) @PathParam("id") String id, | ||
| @Parameter(description = "Url of the endpoint that stream will be republished. If required, please encode the URL", required = true) Endpoint endpoint, | ||
| @Parameter(description = "Resolution height of the broadcast that is wanted to send to the endpoint. ", required = false) @QueryParam("resolutionHeight") int resolutionHeight) { |
There was a problem hiding this comment.
Mention about SRT and RTMP endpoints
| ) | ||
| @DELETE | ||
| @Consumes(MediaType.APPLICATION_JSON) | ||
| @Path("/{id}/rtmp-endpoint") |
There was a problem hiding this comment.
The path is about rtmp-endpoint. Lets make it more generic that is covering the rtmp and srt
|
#4450
https://gitlab.com/Ant-Media/Ant-Media-Enterprise/-/merge_requests/786