8000
Skip to content

Bump JSON Schema version and lower cache size.#789

Merged
kaiwalyajoshi merged 5 commits intomasterfrom
karsten/bump-json-schema
Aug 22, 2020
Merged

Bump JSON Schema version and lower cache size.#789
kaiwalyajoshi merged 5 commits intomasterfrom
karsten/bump-json-schema

Conversation

@jeschkies
Copy link
Copy Markdown
Contributor
@jeschkies jeschkies commented Jun 24, 2020

Summary:
This will lower the memory usage by ignoring the JSON schema cache.
Since we are not using any URIs to load the JSON schema it is cached
each time a new.

JIRA issues: D2IQ-68617

@jeschkies
Bump JSON Schema version and lower cache size.
15d0c75 
Summary:
This will lower the memory usage by ignoring the JSON schema cache.
Since we are not using any URIs to load the JSON schema it is cached
each time a new.

JIRA issues: D2IQ-68617
@jeschkies jeschkies requested a review from pierrebeitz June 24, 2020 14:51
@jeschkies
Copy link
Copy Markdown
Contributor Author
jeschkies commented Jun 24, 2020 •
edited
Loading

The benchmark uses wrk with the following LUA script

❯ cat render_package.lua
wrk.method = "POST"
wrk.body   = '{"appId": "mom", "options": {}, "packageName": "marathon", "packageVersion": "1.7.188"}'
wrk.headers["Accept"] = "application/vnd.dcos.package.render-response+json;charset=utf-8;version=v1"
wrk.headers["Content-Type"] = "application/vnd.dcos.package.render-request+json;charset=utf-8;version=v1"

and is run via

❯ wrk -s render_package.lua -d 5m -t 10 http://127.0.0.1:7070/package/render

This is a run with this patch
benchmark

compare it to the current master
master

@pierrebeitz
Copy link
Copy Markdown
Contributor
pierrebeitz commented Jun 30, 2020

the python-error is fixed by now. next step is to fix masters CI.

@kaiwalyajoshi kaiwalyajoshi merged commit e49fb1b into master Aug 22, 2020
@janisz janisz deleted the karsten/bump-json-schema branch September 28, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@timcharper timcharper timcharper approved these changes

@pierrebeitz pierrebeitz pierrebeitz approved these changes

@janisz janisz janisz approved these changes

@kaiwalyajoshi kaiwalyajoshi kaiwalyajoshi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeschkies @pierrebeitz @timcharper @janisz @kaiwalyajoshi
0