8000
Skip to content

Alpha support for Windows - #1221

Merged
cliffburdick merged 39 commits into
mainfrom
cburdick/pr-1177-windows-build
Aug 7, 2026
Merged

Alpha support for Windows#1221
cliffburdick merged 39 commits into
mainfrom
cburdick/pr-1177-windows-build

Conversation

@cliffburdick
@cliffburdick cliffburdick commented Aug 7, 2026
Copy link
Copy Markdown
Collaborator

Closes #153

Thanks to @zcsizmadia for all the work to get MatX compiling on Windows.

Enable MatX test builds on Windows with Visual Studio 2026 by adding the required MSVC/nvcc compile options, suppressing non-actionable warnings that are promoted by /WX, and fixing conformance issues exposed by the newer compiler. This keeps the default non-JIT CUDA path compiling cleanly with CUDA 13.3, while leaving JIT support disabled/unvalidated on Windows for now.

Note that VS 2022 is not supported.

zcsizmadia added 30 commits August 6, 2026 10:56
@copy-pr-bot
copy-pr-bot Bot commented Aug 7, 2026
Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cliffburdick
cliffburdick commented Aug 7, 2026
Copy link
Copy Markdown
Collaborator Author

/build

@greptile-apps
greptile-apps Bot commented Aug 7, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds alpha Windows support for MatX with MSVC/NVCC build options and compiler-conformance fixes.

  • Selects the CRT mismatch workaround according to each target’s configured MSVC runtime.
  • Restores rank-positive C-array tensor and descriptor overloads while safely excluding rank-zero signatures.
  • Adds Windows-compatible warning handling, types, allocation APIs, and test/build configuration.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
CMakeLists.txt Adds Windows/MSVC compile options and a target-aware CRT mismatch helper; the previously reported static-runtime exclusion is resolved.
test/CMakeLists.txt Applies the runtime-aware link workaround and MSVC-compatible warning options to test targets.
include/matx/core/tensor.h Makes C-array Slice extents dependent and constrained, retaining valid positive-rank overloads on MSVC.
include/matx/core/tensor_desc.h Applies equivalent positive-rank constraints to C-array descriptor constructors without removing valid callers.
include/matx/core/defines.h Adds portable MSVC diagnostic macros and abstracts non-MSVC visibility attributes.

Reviews (2): Last reviewed commit: "Address Windows review feedback" | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Aug 7, 2026
View reviewed changes
Comment thread test/CMakeLists.txt Outdated
Comment thread include/matx/core/tensor.h Outdated
@cliffburdick
cliffburdick merged commit 3c463a9 into main Aug 7, 2026
1 check passed
@cliffburdick
cliffburdick deleted the cburdick/pr-1177-windows-build branch August 7, 2026 19:21
@cliffburdick cliffburdick mentioned this pull request Aug 18, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Visual studio fails to compile unit tests/examples

2 participants

@cliffburdick @zcsizmadia
0