fix(playout): invalid input source disconnect command send to liquidsoap - #3166
Merged
Conversation
The `source_disconnect` method in the liquidsoap client was still using the old names of the 2 harbor input (currently named input_main and input_show). Remove the `source_disconnect` method, in favor of the `source_switch_status` method, to have a single source name mapping between playout and liquidsoap.
|
I guess its worst now, dj connects libretime show that the dj is connected and only get audio from autodj (the default in ls). EDIT: added code blocks |
Contributor
Author
|
@BrixSat I tested again myself and it is working as expected. The auth failures in your logs seem unrelated to the disconnect problem. Also make sure that the auto switch on and off are activated: If you test again and it still does not solve your issue, please open new issue. |
|
Yes booth checkbox's are marked. Will reapply the code. Thanks |
jooola
added a commit
that referenced
this pull request
Jul 16, 2025
🤖 I have created a release *beep* *boop* --- ## [4.5.0](4.4.0...4.5.0) (2025-07-16) ### Features * **legacy:** add config option for group separator in header auth ([#3181](#3181)) ([f780994](f780994)) * **playout:** don't clear liquidsoap queue on liquidsoap startup ([#3163](#3163)) ([0b02ebf](0b02ebf)) * rename `airtime-pypo` exchange to `playout` ([#3170](#3170)) ([63ff50b](63ff50b)) * use fanout queue type for playout queue ([#3161](#3161)) ([9e55d3b](9e55d3b)) ### Bug Fixes * **playout:** invalid input source disconnect command send to liquidsoap ([#3166](#3166)) ([908d548](908d548)) * **playout:** remove potential deadlock in liquidsoap client ([#3165](#3165)) ([f33518d](f33518d)) * **playout:** when metadata has a newline playout stops ([#3160](#3160)) ([d7987bb](d7987bb)) * **worker:** catch mutagen `TypeError` when saving metadata ([#3182](#3182)) ([107bacf](107bacf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net>
paddatrapper
pushed a commit
to libretime/website
that referenced
this pull request
Jul 16, 2025
🤖 I have created a release *beep* *boop* --- ## [4.5.0](libretime/libretime@4.4.0...4.5.0) (2025-07-16) ### Features * **legacy:** add config option for group separator in header auth ([#3181](libretime/libretime#3181)) ([f780994](libretime/libretime@f780994)) * **playout:** don't clear liquidsoap queue on liquidsoap startup ([#3163](libretime/libretime#3163)) ([0b02ebf](libretime/libretime@0b02ebf)) * rename `airtime-pypo` exchange to `playout` ([#3170](libretime/libretime#3170)) ([63ff50b](libretime/libretime@63ff50b)) * use fanout queue type for playout queue ([#3161](libretime/libretime#3161)) ([9e55d3b](libretime/libretime@9e55d3b)) ### Bug Fixes * **playout:** invalid input source disconnect command send to liquidsoap ([#3166](libretime/libretime#3166)) ([908d548](libretime/libretime@908d548)) * **playout:** remove potential deadlock in liquidsoap client ([#3165](libretime/libretime#3165)) ([f33518d](libretime/libretime@f33518d)) * **playout:** when metadata has a newline playout stops ([#3160](libretime/libretime#3160)) ([d7987bb](libretime/libretime@d7987bb)) * **worker:** catch mutagen `TypeError` when saving metadata ([#3182](libretime/libretime#3182)) ([107bacf](libretime/libretime@107bacf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net> libretime/libretime@f429339
paddatrapper
pushed a commit
to libretime/website
that referenced
this pull request
Jul 16, 2025
🤖 I have created a release *beep* *boop* --- ## [4.5.0](libretime/libretime@4.4.0...4.5.0) (2025-07-16) ### Features * **legacy:** add config option for group separator in header auth ([#3181](libretime/libretime#3181)) ([f780994](libretime/libretime@f780994)) * **playout:** don't clear liquidsoap queue on liquidsoap startup ([#3163](libretime/libretime#3163)) ([0b02ebf](libretime/libretime@0b02ebf)) * rename `airtime-pypo` exchange to `playout` ([#3170](libretime/libretime#3170)) ([63ff50b](libretime/libretime@63ff50b)) * use fanout queue type for playout queue ([#3161](libretime/libretime#3161)) ([9e55d3b](libretime/libretime@9e55d3b)) ### Bug Fixes * **playout:** invalid input source disconnect command send to liquidsoap ([#3166](libretime/libretime#3166)) ([908d548](libretime/libretime@908d548)) * **playout:** remove potential deadlock in liquidsoap client ([#3165](libretime/libretime#3165)) ([f33518d](libretime/libretime@f33518d)) * **playout:** when metadata has a newline playout stops ([#3160](libretime/libretime#3160)) ([d7987bb](libretime/libretime@d7987bb)) * **worker:** catch mutagen `TypeError` when saving metadata ([#3182](libretime/libretime#3182)) ([107bacf](libretime/libretime@107bacf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net> libretime/libretime@f429339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
source_disconnectmethod in the liquidsoap client was still using the old names of the 2 harbor input (currently named input_main and input_show).Remove the
source_disconnectmethod, in favor of thesource_switch_statusmethod, to have a single source name mapping between playout and liquidsoap.This is a missing update from a refactor made a while ago: 2f9f60e
Links
Potential fix for #2796