Ensure uses of rxObservable/rxFlowable call send/trySend#375
Merged
Conversation
kierse
commented
May 9, 2025
slack-lint-checks/src/main/java/slack/lint/rx/RxObservableEmitDetector.kt
Show resolved
Hide resolved
ZacSweers
reviewed
May 9, 2025
slack-lint-checks/src/main/java/slack/lint/rx/RxObservableEmitDetector.kt
Outdated
Show resolved
Hide resolved
slack-lint-checks/src/main/java/slack/lint/rx/RxObservableEmitDetector.kt
Show resolved
Hide resolved
cebd687 to
6c799f0
Compare
ZacSweers
reviewed
May 12, 2025
slack-lint-checks/src/main/java/slack/lint/rx/RxObservableEmitDetector.kt
Outdated
Show resolved
Hide resolved
| // If we find a nested factory method, return immediately and stop traversing this | ||
| // code path. | ||
| // Note: this factory will be validated by the UElementHandler above | ||
| if (node.methodName in functionToIssue) return true |
Collaborator
There was a problem hiding this comment.
Would be good to add a test with an import alias just to ensure this isn't defeated by that
slack-lint-checks/src/main/java/slack/lint/rx/RxObservableEmitDetector.kt
Outdated
Show resolved
Hide resolved
ZacSweers
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses of
rxObservable/rxFlowablethat don't callsend/trySendare of limited use and a (potential) source of bugs. This lint flags uses that don't call either method