8000
Skip to content

Allow sealed classes to be Moshi-compatible#431

Merged
ywu96 merged 9 commits intomainfrom
yfw-moshi-sealed-class
Sep 19, 2025
Merged

Allow sealed classes to be Moshi-compatible#431
ywu96 merged 9 commits intomainfrom
yfw-moshi-sealed-class

Conversation

@ywu96
Copy link
Copy Markdown
Collaborator
@ywu96 ywu96 commented Sep 12, 2025 •
edited
Loading

Summary

This PR updates JsonInflaterMoshiCompatibilityDetector to accept sealed interfaces as Moshi-compatible if they're annotated with JsonClass or AdaptedBy.

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

Base automatically changed from yfw-moshi-primitive to main September 17, 2025 21:42
@ywu96 ywu96 requested a review from saifc September 17, 2025 22:32
@ywu96 ywu96 added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit d49c170 Sep 19, 2025
3 checks passed
@ywu96 ywu96 deleted the yfw-moshi-sealed-class branch September 19, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saifc saifc saifc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ywu96 @saifc
0