Add java.util.Calendar to DenyListedApiDetector#351
Conversation
|
Thanks for the contribution! Before we can merge this, we need @jbduncan to sign the Salesforce Inc. Contributor License Agreement. |
|
CLA signed! |
| autoService-ksp = "dev.zacsweers.autoservice:auto-service-ksp:1.2.0" | ||
| junit = "junit:junit:4.13.2" | ||
| kotlin-metadata = { module = "org.jetbrains.kotlin:kotlin-metadata-jvm", version.ref = "kotlin" } | ||
| ktfmt = { module = "com.facebook:ktfmt", version.ref = "ktfmt" } |
There was a problem hiding this comment.
Can you restore this? Curious why it was removed as we use this for formatting
There was a problem hiding this comment.
Certainly. I was curious too, because my IntelliJ IDEA tells me that it's unused, and removing it doesn't cause ./gradlew check to fail.
I think it's because ktfmt under [versions] is used but ktfmt in [libraries] isn't, but I'm happy to be corrected on this.
Anyway, seeing your other comment, I've reverted the change locally and will force-push soon.
| */ | ||
| internal class DenyListedApiDetector : Detector(), SourceCodeScanner, XmlScanner { | ||
|
|
||
| override fun getApplicableUastTypes() = CONFIG.applicableTypes() |
There was a problem hiding this comment.
Can you clean up some of these extraneous refactorings? Would like to keep this addition limited to just the new Calendar entry unless there's some functional change required to make that work
There was a problem hiding this comment.
Certainly! I've removed the commits that introduced the extraneous refactorings locally and will force-push soon.
Summary
This PR fixes #347, aiming to catch usages of
java.util.Calendarand suggestjava.timeinstead.Requirements (place an
xin each[ ])